Page MenuHomePhabricator
Differential D7753

check that a separator is found for psbt inputs, outputs, and global map
ClosedPublic
Actions

Authored by PiRK on Oct 5 2020, 08:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC0bf843494ddc: check that a separator is found for psbt inputs, outputs, and global map
Summary

PR description:
Currently it doesn't make sure that a separator was found so PSBTs missing a trailing separator would still pass. This fixes that and adds a test case for it.

It really only makes sense to check for the separator for the output maps as if an input or global map was missing a separator, the fields following it would be interpreted as belonging to the previous input or global map. However I have added the check for those two anyways to be consistent.

Backport of Core PR14377

Test Plan

ninja && test/functional/test_runner.py rpc_psbt

Diff Detail

Event Timeline

PiRK created this revision.Oct 5 2020, 08:00
Owners added a reviewer: Restricted Owners Package.Oct 5 2020, 08:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2020, 08:01
PiRK requested review of this revision.Oct 5 2020, 08:01
teamcity edited the summary of this revision. (Show Details)Oct 5 2020, 08:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13176: Diff 24240.Oct 5 2020, 08:15
Fabien accepted this revision.Oct 5 2020, 13:34
This revision is now accepted and ready to land.Oct 5 2020, 13:34
Closed by commit rABC0bf843494ddc: check that a separator is found for psbt inputs, outputs, and global map (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyOct 5 2020, 13:48
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0bf843494ddc: check that a separator is found for psbt inputs, outputs, and global map.

Revision Contents
Changeset List

PathSize
src/
24 lines
test/
functional/
data/
4 lines

Diff 24240

View Options

src/psbt.h

Loading...
View Options

test/functional/data/rpc_psbt.json

Loading...