Page MenuHomePhabricator
Differential D7752

Add regtests for HTTP status codes.
ClosedPublic
Actions

Authored by PiRK on Oct 5 2020, 07:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC4c94f3fa8c91: Add regtests for HTTP status codes.
Summary

PR description:

This adds explicit tests for the returned HTTP status codes to
interface_rpc.py (for error cases) and the HTTP JSON-RPC client in
general for success.

PR15381 brought up discussion about the HTTP status codes in general,
and the general opinion was that the current choice may not be ideal
but should not be changed to preserve compatibility with existing
JSON-RPC clients. Thus it makes sense to actually test the current
status to ensure this desired compatibility is not broken accidentally.

This is a backport of Core PR15495

Test Plan

ninja && test/functional/test_runner.py interface_rpc

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 5 2020, 07:11
Owners added a reviewer: Restricted Owners Package.Oct 5 2020, 07:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2020, 07:11
PiRK requested review of this revision.Oct 5 2020, 07:11
teamcity edited the summary of this revision. (Show Details)Oct 5 2020, 07:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13175: Diff 24239.Oct 5 2020, 07:23
PiRK edited the summary of this revision. (Show Details)Oct 5 2020, 11:28
Fabien accepted this revision.Oct 5 2020, 13:32
This revision is now accepted and ready to land.Oct 5 2020, 13:32
Closed by commit rABC4c94f3fa8c91: Add regtests for HTTP status codes. (authored by Daniel Kraft <d@domob.eu>, committed by PiRK). · Explain WhyOct 5 2020, 13:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4c94f3fa8c91: Add regtests for HTTP status codes..

Revision Contents
Changeset List

PathSize
test/
functional/
21 lines
test_framework/
30 lines

Diff 24256

View Options

test/functional/interface_rpc.py

Loading...
View Options

test/functional/test_framework/authproxy.py

Loading...