Don't show addresses of P2PK in decoderawtransaction
ClosedPublic
Actions

Authored by PiRK on Oct 15 2020, 12:16.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCea7128a744c3: Don't show addresses of P2PK in decoderawtransaction

Summary

P2PK scripts don't involve an address.

Backport of Core PR16725

Test Plan

ninja && ninja check

src/bitcoin-cli -regtest decoderawtransaction 01000000010000000000000000000000000000000000000000000000000000000000000000ffffffff4d04ffff001d0104455468652054696d65732030332f4a616e2f32303039204368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73ffffffff0100f2052a01000000434104678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5fac00000000

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr16725

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13430
Build 26892: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26891: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 15 2020, 12:16

Owners added a reviewer: Restricted Owners Package.Oct 15 2020, 12:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 12:16

PiRK requested review of this revision.Oct 15 2020, 12:16

teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 12:17

Harbormaster completed remote builds in B13415: Diff 24655.Oct 15 2020, 12:20

PiRK edited the summary of this revision. (Show Details)Oct 15 2020, 12:21

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[0m[1;30mwallet_hd.py                                     | ○ Skipped | 0 s
[0m[1;30mwallet_import_rescan.py                          | ○ Skipped | 0 s
[0m[1;30mwallet_import_with_label.py                      | ○ Skipped | 0 s
[0m[1;30mwallet_importmulti.py                            | ○ Skipped | 0 s
[0m[1;30mwallet_importprunedfunds.py                      | ○ Skipped | 0 s
[0m[1;30mwallet_keypool.py                                | ○ Skipped | 0 s
[0m[1;30mwallet_keypool_topup.py                          | ○ Skipped | 0 s
[0m[1;30mwallet_labels.py                                 | ○ Skipped | 0 s
[0m[1;30mwallet_listreceivedby.py                         | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py                         | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py                            | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py --usecli                   | ○ Skipped | 0 s
[0m[1;30mwallet_reorgsrestore.py                          | ○ Skipped | 0 s
[0m[1;30mwallet_resendwallettransactions.py               | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py                              | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py --mineblock                  | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py                        | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py --mineblock            | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py                              | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py --usecli                     | ○ Skipped | 0 s
[0m[1;30mwallet_zapwallettxes.py                          | ○ Skipped | 0 s
[0m[0;31mp2p_timeouts.py                                  | ✖ Failed  | 8 s
[0m[0;31m[1m
ALL                                              | ✖ Failed  | 322 s (accumulated) 
[0m[0mRuntime: 71 s

[21/379] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[22/379] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[102/379] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:541:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[155/379] Running seeder test suite
PASSED: seeder test suite
[158/379] Running avalanche test suite
PASSED: avalanche test suite
[165/379] Running pow test suite
PASSED: pow test suite
[373/379] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[378/379] Running bitcoin test suite
PASSED: bitcoin test suite
FAILED: test/CMakeFiles/check-functional 
cd /work/abc-ci-builds/build-without-wallet/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests" --junitoutput=/work/abc-ci-builds/build-without-wallet/test/junit/functional_tests.xml
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_timeouts.py

I'm unable to repoduce the build failure. I tried cmake .. -GNinja -DBUILD_BITCOIN_WALLET=OFF && ninja && test/functional/test_runner.py p2p_timeouts.py

In D7932#186446, @PiRK wrote:

I'm unable to repoduce the build failure. I tried cmake .. -GNinja -DBUILD_BITCOIN_WALLET=OFF && ninja && test/functional/test_runner.py p2p_timeouts.py

Rebase an update the diff then, it'll rerun CI.

This revision now requires changes to proceed.Oct 15 2020, 14:54

rebase

Harbormaster completed remote builds in B13430: Diff 24675.Oct 15 2020, 19:00

deadalnix accepted this revision.Oct 15 2020, 21:55

This revision is now accepted and ready to land.Oct 15 2020, 21:55

Closed by commit rABCea7128a744c3: Don't show addresses of P2PK in decoderawtransaction (authored by nicolas.dorier <nicolas.dorier@gmail.com>, committed by PiRK). · Explain WhyOct 16 2020, 07:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCea7128a744c3: Don't show addresses of P2PK in decoderawtransaction.