Page MenuHomePhabricator
Differential D8014

test: Set catch_system_errors=no on boost unit tests
ClosedPublic
Actions

Authored by jasonbcox on Oct 20 2020, 23:46.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1a60077296f7: test: Set catch_system_errors=no on boost unit tests
Summary

Boost does not handle asserts well in unit tests. Encountering one causes
test_bitcoin to hang indefinitely. This may explain the occassional timeouts we're
experiencing in CI.

See https://www.boost.org/doc/libs/1_68_0/libs/test/doc/html/boost_test/utf_reference/rt_param_reference/catch_system.html

Backport of Core PR18183

Test Plan

Introduce assert(0); into a unit test, then: ninja check
Pre-patch, ninja check hangs until killed (Ctrl+C).
Post-patch, ninja check errors out as expected.

Diff Detail

Event Timeline

jasonbcox created this revision.Oct 20 2020, 23:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2020, 23:46
jasonbcox requested review of this revision.Oct 20 2020, 23:46
teamcity edited the summary of this revision. (Show Details)Oct 20 2020, 23:46
deadalnix accepted this revision.Oct 20 2020, 23:51
This revision is now accepted and ready to land.Oct 20 2020, 23:51
deadalnix added inline comments.Oct 20 2020, 23:52
cmake/modules/TestSuite.cmake
194

If this is static and never changes, you should push it down the stack instead of adding it to every callsites.

Harbormaster completed remote builds in B13545: Diff 24871.Oct 20 2020, 23:58
jasonbcox added inline comments.Oct 21 2020, 00:35
cmake/modules/TestSuite.cmake
194

I agree. I looked into this and it wasn't immediately obvious how to do it without refactoring a lot of code. I will chat with Fabien about it.

Closed by commit rABC1a60077296f7: test: Set catch_system_errors=no on boost unit tests (authored by jasonbcox). · Explain WhyOct 21 2020, 16:04
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC1a60077296f7: test: Set catch_system_errors=no on boost unit tests.

Revision Contents
Changeset List

PathSize
cmake/
modules/
1 line
src/
test/
1 line

Diff 24871

View Options

cmake/modules/TestSuite.cmake

Loading...
View Options

src/test/CMakeLists.txt

Loading...