Page MenuHomePhabricator
Differential D930

Wallet database handling abstraction/simplification
ClosedPublic
Actions

Authored by deadalnix on Jan 11 2018, 00:47.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING3eae70993e6e: Wallet database handling abstraction/simplification
rABC3eae70993e6e: Wallet database handling abstraction/simplification
Summary

Backport core's PR9951

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletdbsimplify
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1597
Build 1597: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 11 2018, 00:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2018, 00:47
Harbormaster completed remote builds in B1570: Diff 2446.Jan 11 2018, 00:47
deadalnix planned changes to this revision.Jan 11 2018, 01:02

This is not finished.

deadalnix updated this revision to Diff 2447.Jan 11 2018, 15:24

Finish the work

Harbormaster completed remote builds in B1571: Diff 2447.Jan 11 2018, 15:24
deadalnix updated this revision to Diff 2466.Jan 12 2018, 18:27

Make IsDummy private

Harbormaster completed remote builds in B1585: Diff 2466.Jan 12 2018, 18:27
deadalnix added a child revision: D946: Basic multiwallet support.Jan 14 2018, 02:20
schancel added inline comments.Jan 14 2018, 03:48
src/wallet/db.h
214 ↗(On Diff #2466)

huhdog

deadalnix added inline comments.Jan 14 2018, 14:10
src/wallet/db.h
214 ↗(On Diff #2466)

The behavior from non backed wallet is that all write succeed and all read fail. You can check the original PR for details.

deadalnix updated this revision to Diff 2490.Jan 14 2018, 14:18

Rebase and fix conflict

Harbormaster completed remote builds in B1597: Diff 2490.Jan 14 2018, 14:18
schancel accepted this revision.Jan 16 2018, 02:51
This revision is now accepted and ready to land.Jan 16 2018, 02:51
Closed by commit rABC3eae70993e6e: Wallet database handling abstraction/simplification (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by deadalnix). · Explain WhyJan 16 2018, 12:57
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
test/
4 lines
wallet/
59 lines
138 lines
2 lines
test/
4 lines
59 lines
35 lines
283 lines
47 lines
155 lines

Diff 2490

View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.cpp

Loading...
View Options

src/wallet/test/walletdb_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...