Differential D8035

test: follow-up to rpc: default maxfeerate value as BCH/kB
ClosedPublic
Actions

Authored by deadalnix on Oct 21 2020, 22:57.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC005230930fc2: test: follow-up to rpc: default maxfeerate value as BCH/kB

Summary

test: fix incorrect value in rpc_rawtransaction.py
doc: improve rawtransaction code/test docs
test: use named args for sendrawtransaction calls

involving more than one argument.

This is a backport of Core PR16929

Depends on D8027

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16929

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13575
Build 27181: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 27180: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 21 2020, 22:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2020, 22:57

deadalnix requested review of this revision.Oct 21 2020, 22:57

teamcity edited the summary of this revision. (Show Details)Oct 21 2020, 22:57

Harbormaster completed remote builds in B13575: Diff 24922.Oct 21 2020, 23:10

Fabien accepted this revision.Oct 22 2020, 06:29

This revision is now accepted and ready to land.Oct 22 2020, 06:29

Closed by commit rABC005230930fc2: test: follow-up to rpc: default maxfeerate value as BCH/kB (authored by Jon Atack <jon@atack.com>, committed by deadalnix). · Explain WhyOct 22 2020, 11:10

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC005230930fc2: test: follow-up to rpc: default maxfeerate value as BCH/kB.

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

6 lines

test/

functional/

rpc_rawtransaction.py

21 lines

wallet_basic.py

15 lines

Diff 24922

View Options

src/rpc/rawtransaction.cpp

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/wallet_basic.py

test: follow-up to rpc: default maxfeerate value as BCH/kBClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24922

src/rpc/rawtransaction.cpp

test/functional/rpc_rawtransaction.py

test/functional/wallet_basic.py

test: follow-up to rpc: default maxfeerate value as BCH/kB
ClosedPublic
Actions

Revision Contents
Changeset List