Page MenuHomePhabricator
Differential D8027

rpc: Use the default maxfeerate value as BCH/kB
ClosedPublic
Actions

Authored by deadalnix on Oct 21 2020, 15:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC04e6d1809aab: rpc: Use the default maxfeerate value as BCH/kB
Summary
  • wallet/rpc: Use the default maxfeerate value as BTC/kB
  • test: Add test for default maxfeerate in sendrawtransaction

This patch adds test for the following case

  • maxfeerate is omitted, and the actual fee rate is higher than the default value(0.1 BTC/kB)

This is a backport of Core PR16521

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 21 2020, 15:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2020, 15:03
deadalnix requested review of this revision.Oct 21 2020, 15:03
teamcity edited the summary of this revision. (Show Details)Oct 21 2020, 15:03
Harbormaster completed remote builds in B13563: Diff 24898.Oct 21 2020, 15:17
Fabien requested changes to this revision.Oct 21 2020, 15:42
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_rawtransaction.py
551 ↗(On Diff #24898)

That's wrong ?
Edit: https://github.com/bitcoin/bitcoin/pull/16929

587 ↗(On Diff #24898)

Nit: BTC => BCH

This revision now requires changes to proceed.Oct 21 2020, 15:42
deadalnix updated this revision to Diff 24921.Oct 21 2020, 22:50

rebase and fix BTC => BCH

deadalnix added a child revision: D8035: test: follow-up to rpc: default maxfeerate value as BCH/kB.Oct 21 2020, 22:57
Harbormaster completed remote builds in B13574: Diff 24921.Oct 21 2020, 23:02
Fabien accepted this revision.Oct 22 2020, 06:27
This revision is now accepted and ready to land.Oct 22 2020, 06:27
Fabien mentioned this in D8048: [backport#16521 1/2] wallet/rpc: Use the default maxfeerate value as BTC/kB.Oct 22 2020, 09:33
PiRK mentioned this in D8052: [backport#16251 2/2]test: Add test for default maxfeerate in sendrawtransaction.Oct 22 2020, 09:51
PiRK mentioned this in D8051: [backport#16078 2/2] minor changes in maxfeerate test.Oct 22 2020, 09:55
PiRK mentioned this in D8050: [backport#16078] replace tx hash with txid in test rawtransaction.Oct 22 2020, 09:57
Closed by commit rABC04e6d1809aab: rpc: Use the default maxfeerate value as BCH/kB (authored by Joonmo Yang <dev@remagpie.com>, committed by deadalnix). · Explain WhyOct 22 2020, 11:03
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC04e6d1809aab: rpc: Use the default maxfeerate value as BCH/kB.
PiRK mentioned this in rABC8244813e382f: [backport#16078] replace tx hash with txid in test rawtransaction.Oct 22 2020, 19:53

Revision Contents
Changeset List

PathSize
src/
rpc/
35 lines
test/
functional/
1 line
40 lines
2 lines

Diff 24942

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/mempool_accept.py

Loading...
View Options

test/functional/rpc_rawtransaction.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...