Page MenuHomePhabricator
Differential D8050

[backport#16078] replace tx hash with txid in test rawtransaction
ClosedPublic
Actions

Authored by PiRK on Oct 22 2020, 09:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC8244813e382f: [backport#16078] replace tx hash with txid in test rawtransaction
Summary

Comment by @sipa:

txid is correct here, as it's about arguments to the gettransansaction RPC.

This is a partial backport of Core PR16078
Commit https://github.com/bitcoin/bitcoin/pull/16078/commits/a65dafa8f12b3776328ace5cef24cb3fd126cfb1

The next commit is not needed as its changes are overwritten in D8027 / PR16251

See D1556 for why we have additional lines changed.

Test Plan

ninja && ninja && test/functional/test_runner.py rpc_rawtransaction.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 22 2020, 09:37
Owners added a reviewer: Restricted Owners Package.Oct 22 2020, 09:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 09:37
PiRK requested review of this revision.Oct 22 2020, 09:37
teamcity edited the summary of this revision. (Show Details)Oct 22 2020, 09:37
PiRK added a child revision: D8051: [backport#16078 2/2] minor changes in maxfeerate test.Oct 22 2020, 09:43
PiRK edited the summary of this revision. (Show Details)Oct 22 2020, 09:56
PiRK retitled this revision from [backport#16078 1/2] replace tx hash with txid in test rawtransaction to [backport#16078] replace tx hash with txid in test rawtransaction.
PiRK edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B13591: Diff 24939.Oct 22 2020, 10:05
deadalnix accepted this revision.Oct 22 2020, 11:00
This revision is now accepted and ready to land.Oct 22 2020, 11:00
Closed by commit rABC8244813e382f: [backport#16078] replace tx hash with txid in test rawtransaction (authored by LongShao007 <007longshao@gmail.com>, committed by PiRK). · Explain WhyOct 22 2020, 19:54
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8244813e382f: [backport#16078] replace tx hash with txid in test rawtransaction.

Revision Contents
Changeset List

PathSize
test/
functional/
35 lines

Diff 24964

View Options

test/functional/rpc_rawtransaction.py

Loading...