Differential D8043

[SECP256K1] Check correctness of lambda split without -DVERIFY
ClosedPublic
Actions

Authored by Fabien on Oct 22 2020, 08:58.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC9fcb376c78da: [SECP256K1] Check correctness of lambda split without -DVERIFY

Summary

The VERIFY macro turns on various paranoid consistency checks, but the
complete functionality should still be tested without it.

This also adds a couple of static test points for extremely small split
inputs/outputs. The existing bounds vectors already check extremely
large outputs.

Partial backport 7/11 of secp256k1 PR830:
https://github.com/bitcoin-core/secp256k1/pull/830/commits/ebad8414b0e68041568d0b5ebe0bd395dbfbed9e

Depends on D8042.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR830_part7

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13584
Build 27199: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 27198: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 22 2020, 08:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 08:58

Fabien requested review of this revision.Oct 22 2020, 08:58

teamcity edited the summary of this revision. (Show Details)Oct 22 2020, 08:59

Fabien added a child revision: D8044: [SECP256K1] Rip out non-endomorphism code.Oct 22 2020, 09:08

Harbormaster completed remote builds in B13584: Diff 24932.Oct 22 2020, 09:17

Fabien retitled this revision from Check correctness of lambda split without -DVERIFY to [SECP256K1] Check correctness of lambda split without -DVERIFY.Oct 22 2020, 09:31

deadalnix accepted this revision.Oct 22 2020, 11:59

This revision is now accepted and ready to land.Oct 22 2020, 11:59

Closed by commit rABC9fcb376c78da: [SECP256K1] Check correctness of lambda split without -DVERIFY (authored by Gregory Maxwell <greg@xiph.org>, committed by Fabien). · Explain WhyOct 22 2020, 19:58

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9fcb376c78da: [SECP256K1] Check correctness of lambda split without -DVERIFY.