Differential D8044

[SECP256K1] Rip out non-endomorphism code
ClosedPublic
Actions

Authored by Fabien on Oct 22 2020, 09:08.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCa4e1c1dc5e64: [SECP256K1] Rip out non-endomorphism code

Summary

Partial backport 8/11 of secp256k1 PR830:
https://github.com/bitcoin-core/secp256k1/pull/830/commits/4232e5b7da0a68adc14fa4b481f7e106403c200d

Updates are necessary to accomodate our build system and Travis
variations.

Depends on D8043.

Test Plan

ninja check-secp256k1
make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 22 2020, 09:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2020, 09:08

Fabien requested review of this revision.Oct 22 2020, 09:08

teamcity edited the summary of this revision. (Show Details)Oct 22 2020, 09:08

Fabien added a child revision: D8045: [SECP256K1] WNAF of lambda_split output has max size 129.Oct 22 2020, 09:11

Fabien added a child revision: D8049: [SECP256K1] Stop treating ECDH as experimental.Oct 22 2020, 09:30

Fabien retitled this revision from Rip out non-endomorphism code to [SECP256K1] Rip out non-endomorphism code.Oct 22 2020, 09:32

Harbormaster completed remote builds in B13585: Diff 24933.Oct 22 2020, 09:37

deadalnix accepted this revision.Oct 22 2020, 11:51

This revision is now accepted and ready to land.Oct 22 2020, 11:51

Closed by commit rABCa4e1c1dc5e64: [SECP256K1] Rip out non-endomorphism code (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyOct 22 2020, 19:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa4e1c1dc5e64: [SECP256K1] Rip out non-endomorphism code.

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.yml

7 lines

src/

secp256k1/

19 lines

6 lines

2 lines

13 lines

src/

1 line

4 lines

2 lines

20 lines

145 lines

2 lines

2 lines

libsecp256k1-config.h.cmake.in

1 line

2 lines

2 lines

2 lines

2 lines

29 lines

4 lines

travis/

build_autotools.sh

1 line

build_cmake.sh

1 line

Diff 24969

View Options

contrib/teamcity/build-configurations.yml

View Options

src/secp256k1/.travis.yml

View Options

src/secp256k1/CMakeLists.txt

View Options

src/secp256k1/README.md

View Options

src/secp256k1/configure.ac

View Options

src/secp256k1/src/basic-config.h

View Options

src/secp256k1/src/bench_internal.c

View Options

src/secp256k1/src/ecmult.h

View Options

src/secp256k1/src/ecmult_const_impl.h

View Options

src/secp256k1/src/ecmult_impl.h

View Options

src/secp256k1/src/group.h

View Options

src/secp256k1/src/group_impl.h

View Options

src/secp256k1/src/libsecp256k1-config.h.cmake.in

View Options

src/secp256k1/src/scalar.h

View Options

src/secp256k1/src/scalar_4x64_impl.h

View Options

src/secp256k1/src/scalar_8x32_impl.h

View Options

src/secp256k1/src/scalar_impl.h

View Options

src/secp256k1/src/tests.c

View Options

src/secp256k1/src/tests_exhaustive.c

View Options

src/secp256k1/travis/build_autotools.sh

View Options

src/secp256k1/travis/build_cmake.sh

[SECP256K1] Rip out non-endomorphism codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24969

contrib/teamcity/build-configurations.yml

src/secp256k1/.travis.yml

src/secp256k1/CMakeLists.txt

src/secp256k1/README.md

src/secp256k1/configure.ac

src/secp256k1/src/basic-config.h

src/secp256k1/src/bench_internal.c

src/secp256k1/src/ecmult.h

src/secp256k1/src/ecmult_const_impl.h

src/secp256k1/src/ecmult_impl.h

src/secp256k1/src/group.h

src/secp256k1/src/group_impl.h

src/secp256k1/src/libsecp256k1-config.h.cmake.in

src/secp256k1/src/scalar.h

src/secp256k1/src/scalar_4x64_impl.h

src/secp256k1/src/scalar_8x32_impl.h

src/secp256k1/src/scalar_impl.h

src/secp256k1/src/tests.c

src/secp256k1/src/tests_exhaustive.c

src/secp256k1/travis/build_autotools.sh

src/secp256k1/travis/build_cmake.sh

[SECP256K1] Rip out non-endomorphism code
ClosedPublic
Actions

Revision Contents
Changeset List