Page MenuHomePhabricator
Differential D946

Basic multiwallet support
ClosedPublic
Actions

Authored by deadalnix on Jan 14 2018, 02:20.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING78defe4b6bc6: Basic multiwallet support
rABC78defe4b6bc6: Basic multiwallet support
Summary

Backport of core's PR8694

Depends on D930

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
multiwallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1613
Build 1613: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 14 2018, 02:20
Harbormaster completed remote builds in B1596: Diff 2487.Jan 14 2018, 02:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2018, 02:20
Herald added a reviewer: Restricted Project. · View Herald Transcript
schancel added a comment.Jan 14 2018, 06:03

Unless I'm mistaken, this eventually will call down to:

src/wallet/db.cpp
177:    int result = bitdb.dbenv->dbrename(nullptr, filename.c_str(), nullptr,

The behavior of an empty filename isn't specified by that function, and I don't see any protection around that anywhere in the codebase.

src/wallet/db.cpp
275 ↗(On Diff #2487)

backup_filename is ""

src/wallet/wallet.cpp
544 ↗(On Diff #2487)

backup_filename is ""

deadalnix updated this revision to Diff 2516.Jan 15 2018, 12:39

rebase

Harbormaster completed remote builds in B1613: Diff 2516.Jan 15 2018, 12:39
schancel accepted this revision.Jan 16 2018, 02:52
This revision is now accepted and ready to land.Jan 16 2018, 02:52
Closed by commit rABC78defe4b6bc6: Basic multiwallet support (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by deadalnix). · Explain WhyJan 16 2018, 12:58
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
18 lines
qt/
5 lines
wallet/
31 lines
27 lines
3 lines
test/
2 lines
14 lines
5 lines
103 lines
31 lines
166 lines

Diff 2516

View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...