Differential D8154

util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.
ClosedPublic
Actions

Authored by Fabien on Oct 28 2020, 13:07.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCbd611af6fa23: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.

Summary

Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.

Backport of core PR17721.

Depends on D8153.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR17721

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13715
Build 27450: Build Diff	lint-circular-dependencies · build-clang · build-clang-tidy · build-diff · build-without-wallet · build-debug
Build 27449: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 28 2020, 13:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 28 2020, 13:07

Fabien requested review of this revision.Oct 28 2020, 13:07

teamcity edited the summary of this revision. (Show Details)Oct 28 2020, 13:07

Harbormaster completed remote builds in B13715: Diff 25176.Oct 28 2020, 13:17

Fabien added a child revision: D8155: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests..Oct 28 2020, 13:23

deadalnix accepted this revision.Oct 28 2020, 13:34

This revision is now accepted and ready to land.Oct 28 2020, 13:34

Closed by commit rABCbd611af6fa23: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests. (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyOct 28 2020, 13:57

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCbd611af6fa23: util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests..

Revision Contents
Changeset List

Path

Size

src/

base58.cpp

7 lines

test/

base58_tests.cpp

16 lines

util/

strencodings.cpp

3 lines

string.h

10 lines

Diff 25176

View Options

src/base58.cpp

View Options

src/test/base58_tests.cpp

View Options

src/util/strencodings.cpp

View Options

util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25176

src/base58.cpp

src/test/base58_tests.cpp

src/util/strencodings.cpp

src/util/string.h

util: Don't allow Base58 decoding of non-Base58 strings. Add Base58 tests.
ClosedPublic
Actions

Revision Contents
Changeset List