Page MenuHomePhabricator

Add util_ArgParsing test
ClosedPublic

Authored by PiRK on Nov 4 2020, 09:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC06cb9dd7803e: Add util_ArgParsing test
Summary

ArgsManager test coverage for parsing of integer and boolean values is
currently very poor and doesn't give us a way of knowing whether changes to
ArgsManager may unintentionally break backwards compatibility, so this adds a
new test to catch regressions.

This is a backport of Core PR17390

Test Plan

ninja && ninja check

Diff Detail

Event Timeline

Owners added a reviewer: Restricted Owners Package.Nov 4 2020, 09:41
PiRK requested review of this revision.Nov 4 2020, 09:41

Tail of the build log:

[243/419] bitcoin: testing descriptor_tests
[244/419] bitcoin: testing interfaces_tests
[245/419] bitcoin: testing ismine_tests
[246/419] bitcoin: testing script_standard_tests
[247/419] Running utility command for check-bitcoin-descriptor_tests
[248/419] Running utility command for check-bitcoin-interfaces_tests
[249/419] Running utility command for check-bitcoin-ismine_tests
[250/419] Running utility command for check-bitcoin-script_standard_tests
[251/419] bitcoin: testing dbwrapper_tests
[252/419] bitcoin: testing scriptnum_tests
[253/419] bitcoin: testing db_tests
[254/419] Running utility command for check-bitcoin-dbwrapper_tests
[255/419] Running utility command for check-bitcoin-scriptnum_tests
[256/419] bitcoin: testing mempool_tests
[257/419] bitcoin: testing sanity_tests
[258/419] Running utility command for check-bitcoin-db_tests
[259/419] bitcoin: testing policyestimator_tests
[260/419] Running utility command for check-bitcoin-mempool_tests
[261/419] Running utility command for check-bitcoin-sanity_tests
[262/419] bitcoin: testing merkle_tests
[263/419] Running utility command for check-bitcoin-policyestimator_tests
[264/419] Running utility command for check-bitcoin-merkle_tests
[265/419] bitcoin: testing denialofservice_tests
[266/419] bitcoin: testing getarg_tests
[267/419] Running utility command for check-bitcoin-denialofservice_tests
[268/419] bitcoin: testing cashaddrenc_tests
[269/419] Running utility command for check-bitcoin-getarg_tests
[270/419] bitcoin: testing base32_tests
[271/419] bitcoin: testing hash_tests
[272/419] Running utility command for check-bitcoin-cashaddrenc_tests
[273/419] Running utility command for check-bitcoin-base32_tests
[274/419] bitcoin: testing script_bitfield_tests
[275/419] bitcoin: testing arith_uint256_tests
[276/419] bitcoin: testing key_io_tests
[277/419] bitcoin: testing blockchain_tests
[278/419] bitcoin: testing checkdatasig_tests
[279/419] Running utility command for check-bitcoin-hash_tests
[280/419] bitcoin: testing coinselector_tests
FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,test_suite:JUNIT,message,bitcoin-coinselector_tests.xml --catch_system_errors=no
Running 4 test cases...
Entering test module "Bitcoin ABC unit tests"
../../src/wallet/test/coinselector_tests.cpp(22): Entering test suite "coinselector_tests"
../../src/wallet/test/coinselector_tests.cpp(149): Entering test case "bnb_search_test"
Segmentation fault (core dumped)
[281/419] Running utility command for check-bitcoin-script_bitfield_tests
[282/419] bitcoin: testing op_reversebytes_tests
[283/419] bitcoin: testing sigencoding_tests
[284/419] bitcoin: testing bitmanip_tests
[285/419] Running utility command for check-bitcoin-key_io_tests
[286/419] Running utility command for check-bitcoin-arith_uint256_tests
[287/419] Running utility command for check-bitcoin-blockchain_tests
[288/419] Running utility command for check-bitcoin-checkdatasig_tests
[289/419] bitcoin: testing txvalidation_tests
[290/419] bitcoin: testing rpc_tests
[291/419] bitcoin: testing cuckoocache_tests
[292/419] bitcoin: testing checkqueue_tests
[293/419] secp256k1: testing secp256k1-tests
ninja: build stopped: subcommand failed.
Build build-clang failed with exit code 1

rebase (seemingly unrelated test failure?)

This revision is now accepted and ready to land.Nov 4 2020, 16:58
This revision was automatically updated to reflect the committed changes.