Paths

Table of Contentst

Differential D8424

qa: Fix double-negative arg test
ClosedPublic
Actions

Authored by PiRK on Nov 16 2020, 15:05.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC19458b9aa1e0: qa: Fix double-negative arg test

Summary

The test is made more robust by not accept trailing characters after 0.
This change was made after the test failed to fail when a bug was introduced (pointer address used instead of the string in a LogPrintf call).

This is a backport of Core PR17893

Test Plan

ninja && test/functional/test_runner.py feature_config_args.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17893

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14061
Build 28125: Build Diff	build-without-wallet · build-diff · lint-circular-dependencies · build-clang · build-clang-tidy · build-debug
Build 28124: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 16 2020, 15:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2020, 15:05

PiRK requested review of this revision.Nov 16 2020, 15:05

teamcity edited the summary of this revision. (Show Details)Nov 16 2020, 15:05

majcosta accepted this revision.Nov 16 2020, 15:06

This revision is now accepted and ready to land.Nov 16 2020, 15:06

Harbormaster completed remote builds in B14061: Diff 25790.Nov 16 2020, 15:18

Closed by commit rABC19458b9aa1e0: qa: Fix double-negative arg test (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyNov 17 2020, 09:36

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC19458b9aa1e0: qa: Fix double-negative arg test.

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_config_args.py

2 lines

Diff 25790

test/functional/feature_config_args.py

Loading...