Differential D8648

refactor: Fix unreachable code in init arg checks
ClosedPublic
Actions

Authored by Fabien on Dec 10 2020, 20:03.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC6c84fca7a26e: refactor: Fix unreachable code in init arg checks

Summary

Backport of core PR19131.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19131

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14374
Build 28723: Build Diff	build-diff · build-clang · build-debug · lint-circular-dependencies · build-without-wallet · build-clang-tidy
Build 28722: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 10 2020, 20:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2020, 20:03

Fabien requested review of this revision.Dec 10 2020, 20:03

teamcity edited the summary of this revision. (Show Details)Dec 10 2020, 20:03

Harbormaster completed remote builds in B14374: Diff 26312.Dec 10 2020, 20:17

majcosta accepted this revision.Dec 10 2020, 20:23

This revision is now accepted and ready to land.Dec 10 2020, 20:23

Fabien added a child revision: D8649: Pass bilingual_str argument to AbortNode().Dec 10 2020, 20:24

Closed by commit rABC6c84fca7a26e: refactor: Fix unreachable code in init arg checks (authored by Jonathan Schoeller <jonathan.schoeller@rea-group.com>, committed by Fabien). · Explain WhyDec 10 2020, 23:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6c84fca7a26e: refactor: Fix unreachable code in init arg checks.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

init.cpp

26 lines

util/

translation.h

2 lines

test/

functional/

feature_config_args.py

1 line

Diff 26312

View Options

src/CMakeLists.txt

View Options

src/init.cpp

View Options

src/util/translation.h

View Options

test/functional/feature_config_args.py

refactor: Fix unreachable code in init arg checksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26312

src/CMakeLists.txt

src/init.cpp

src/util/translation.h

test/functional/feature_config_args.py

refactor: Fix unreachable code in init arg checks
ClosedPublic
Actions

Revision Contents
Changeset List