Page MenuHomePhabricator

gui: Partially revert #10244 gArgs and Params changes
ClosedPublic

Authored by Fabien on Dec 10 2020, 23:26.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCc2a91846537e: gui: Partially revert #10244 gArgs and Params changes
Summary
Change gui code to use gArgs, Params() functions directly instead of
going through interfaces::Node.

Remotely accessing bitcoin-node ArgsManager from bitcoin-gui works fine
in https://github.com/bitcoin/bitcoin/pull/10102, when bitcoin-gui
spawns a new bitcoin-node process and controls its startup, but for
bitcoin-gui to support -ipcconnect option in
https://github.com/bitcoin/bitcoin/pull/19461 and connect to an existing
bitcoin-node process, it needs ability to parse arguments itself before
connecting out.

This change also simplifies
https://github.com/bitcoin/bitcoin/pull/10102 a bit, by making the
bitcoin-gui -> bitcoin-node startup sequence more similar to the
bitcoin-node -> bitcoin-wallet startup sequence where the parent process
parses arguments and passes them to the child process instead of the
parent process using the child process to parse arguments.

Partial backport (1/4) of bitcoin-core/gui PR35:
https://github.com/bitcoin-core/gui/pull/35/commits/e1336316250ab5cb0ed654b1e593378a6e0769ce

Depends on D8651.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable