HomePhabricator

gui: Partially revert #10244 gArgs and Params changes

Description

gui: Partially revert #10244 gArgs and Params changes

Summary:

Change gui code to use gArgs, Params() functions directly instead of
going through interfaces::Node.

Remotely accessing bitcoin-node ArgsManager from bitcoin-gui works fine
in https://github.com/bitcoin/bitcoin/pull/10102, when bitcoin-gui
spawns a new bitcoin-node process and controls its startup, but for
bitcoin-gui to support -ipcconnect option in
https://github.com/bitcoin/bitcoin/pull/19461 and connect to an existing
bitcoin-node process, it needs ability to parse arguments itself before
connecting out.

This change also simplifies
https://github.com/bitcoin/bitcoin/pull/10102 a bit, by making the
bitcoin-gui -> bitcoin-node startup sequence more similar to the
bitcoin-node -> bitcoin-wallet startup sequence where the parent process
parses arguments and passes them to the child process instead of the
parent process using the child process to parse arguments.

Partial backport (1/4) of bitcoin-core/gui PR35:
https://github.com/bitcoin-core/gui/pull/35/commits/e1336316250ab5cb0ed654b1e593378a6e0769ce

Depends on D8651.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D8653

Details

Provenance
Russell Yanofsky <russ@yanofsky.org>Authored on Aug 23 2018, 17:42
FabienCommitted on Dec 14 2020, 07:56
FabienPushed on Dec 14 2020, 07:57
Reviewer
Restricted Project
Differential Revision
D8653: gui: Partially revert #10244 gArgs and Params changes
Parents
rABC29d51c3416b7: refactor: Error message bilingual_str consistency
Branches
Unknown
Tags
Unknown