Differential D8713

[net/refactor] Add manual connections to ConnectionType enum
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 11:12.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC46c6dfa25102: [net/refactor] Add manual connections to ConnectionType enum

Summary

Partial backport (3/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/1521c47438537e192230486dffcec0228a53878d

Depends on D8712.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19316_p3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14464
Build 28892: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28891: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 11:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 11:12

Fabien requested review of this revision.Dec 21 2020, 11:12

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 11:13

Fabien added a child revision: D8714: [net/refactor] Add feeler connections to ConnectionType enum.Dec 21 2020, 11:17

Harbormaster completed remote builds in B14464: Diff 26459.Dec 21 2020, 11:26

Fabien edited the summary of this revision. (Show Details)Dec 21 2020, 11:39

majcosta accepted this revision.Dec 21 2020, 12:45

This revision is now accepted and ready to land.Dec 21 2020, 12:45

Closed by commit rABC46c6dfa25102: [net/refactor] Add manual connections to ConnectionType enum (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC46c6dfa25102: [net/refactor] Add manual connections to ConnectionType enum.

Revision Contents
Changeset List

Path

Size

src/

net.h

16 lines

net.cpp

47 lines

rpc/

net.cpp

5 lines

test/

fuzz/

process_messages.cpp

3 lines

Diff 26459

View Options

src/net.h

View Options

src/net.cpp

View Options

src/rpc/net.cpp

View Options

src/test/fuzz/process_messages.cpp

[net/refactor] Add manual connections to ConnectionType enumClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26459

src/net.h

src/net.cpp

src/rpc/net.cpp

src/test/fuzz/process_messages.cpp

[net/refactor] Add manual connections to ConnectionType enum
ClosedPublic
Actions

Revision Contents
Changeset List