Differential D8750

[backport#16969] refactor: Remove Qt function to disable menu icons on macOS
ClosedPublic
Actions

Authored by majcosta on Dec 24 2020, 03:34.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC75d4f4c0c883: [backport#16969] refactor: Remove Qt function to disable menu icons on macOS

Summary

3eea6a8f2686352a0fd868fee6af42ef1283bdda refactor: Remove Qt function to disable menu icons on macOS (Emil Engler)

Pull request description:

As menu icons were removed in #16612, this removes an unnecessary function for macOS
Could this get into v0.19.0?

Backport of Core PR16969

Depends on D8749

Test Plan

ninja all

Unfortunately I have no macOS to test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16969

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14517
Build 28996: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 28995: arc lint + arc unit

Event Timeline

majcosta created this revision.Dec 24 2020, 03:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 24 2020, 03:34

majcosta requested review of this revision.Dec 24 2020, 03:34

teamcity edited the summary of this revision. (Show Details)Dec 24 2020, 03:34

Harbormaster completed remote builds in B14517: Diff 26550.Dec 24 2020, 04:00

PiRK accepted this revision.Dec 24 2020, 13:50

This revision is now accepted and ready to land.Dec 24 2020, 13:50

Closed by commit rABC75d4f4c0c883: [backport#16969] refactor: Remove Qt function to disable menu icons on macOS (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyDec 24 2020, 16:02

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC75d4f4c0c883: [backport#16969] refactor: Remove Qt function to disable menu icons on macOS.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoin.cpp

3 lines

Diff 26550

View Options

[backport#16969] refactor: Remove Qt function to disable menu icons on macOSClosedPublicActions