Page MenuHomePhabricator
Differential D8810

[cashtab] Fix fbt generating translation files
AbandonedPublic
Actions

Authored by alcipir on Jan 6 2021, 23:17.

Details

Reviewers
deadalnix
bytesofman
Group Reviewers
Restricted Project
Summary

This diff fixes the issue where running the app locally or building it generated the same files but removed a line from them.

Test Plan

Run npm clean-fbts, then npm start and see if the translation files are changed.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-fix-fbt-translations
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14606
Build 29171: Build Diff
Build 29170: arc lint + arc unit

Event Timeline

alcipir created this revision.Jan 6 2021, 23:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2021, 23:17
alcipir requested review of this revision.Jan 6 2021, 23:17
Harbormaster completed remote builds in B14606: Diff 26698.Jan 6 2021, 23:17
alcipir added reviewers: deadalnix, bytesofman.Jan 6 2021, 23:29
deadalnix requested changes to this revision.Jan 7 2021, 00:00

There is no explanation as to what problem this solves and why does it solve it.

What was the problem with some command being passed the --pretty flag? What does prepare-fbts do?

This revision now requires changes to proceed.Jan 7 2021, 00:00
deadalnix added a comment.Jan 7 2021, 00:01

There is no explanation as to what problem this solves and why does it solve it.

What was the problem with some command being passed the --pretty flag? What does prepare-fbts do?

alcipir abandoned this revision.Jan 7 2021, 05:33

Revision Contents
Changeset List

PathSize
web/
cashtab/
9 lines

Diff 26698

View Options

web/cashtab/package.json

Loading...