Differential D8860

[test framework] Simplify version message handling
ClosedPublic
Actions

Authored by deadalnix on Jan 9 2021, 21:00.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3584de484d22: [test framework] Simplify version message handling

Summary

We do not expect to run outdated version of the software through this test framework, so hanling outdated version messages is just dead code.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

testversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14683
Build 29325: Build Diff	build-diff · build-without-wallet · build-clang-tidy · build-clang · build-debug
Build 29324: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 9 2021, 21:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 9 2021, 21:00

deadalnix requested review of this revision.Jan 9 2021, 21:00

Harbormaster completed remote builds in B14683: Diff 26824.Jan 9 2021, 21:13

PiRK accepted this revision.Jan 9 2021, 21:59

This revision is now accepted and ready to land.Jan 9 2021, 21:59

deadalnix added a child revision: D8861: [net] Add extra entropy to the version message.Jan 9 2021, 22:02

Closed by commit rABC3584de484d22: [test framework] Simplify version message handling (authored by deadalnix). · Explain WhyJan 9 2021, 22:03

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC3584de484d22: [test framework] Simplify version message handling.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

messages.py

9 lines

Diff 26824

View Options

test/functional/test_framework/messages.py

[test framework] Simplify version message handlingClosedPublicActions