lockedpool: avoid sensitive data in core files (FreeBSD)
ClosedPublic
Actions

Authored by PiRK on Jan 12 2021, 10:23.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rABC72559fd6560a: lockedpool: avoid sensitive data in core files (FreeBSD)

Summary

This is a followup to PR15600 to also use madvise(2) on FreeBSD
to avoid sensitive data allocated with secure_allocator ending up
in core files in addition to preventing it from going to the swap.

This is a backport of Core PR18443

Depends on D8879

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 12 2021, 10:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2021, 10:23

PiRK requested review of this revision.Jan 12 2021, 10:23

teamcity edited the summary of this revision. (Show Details)Jan 12 2021, 10:23

PiRK edited the summary of this revision. (Show Details)Jan 12 2021, 10:26

PiRK edited the summary of this revision. (Show Details)

PiRK added a parent revision: D8879: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps.

Harbormaster completed remote builds in B14715: Diff 26871.Jan 12 2021, 10:39

deadalnix accepted this revision.Jan 12 2021, 10:57

This revision is now accepted and ready to land.Jan 12 2021, 10:57

Fabien accepted this revision.Jan 12 2021, 12:09

Closed by commit rABC72559fd6560a: lockedpool: avoid sensitive data in core files (FreeBSD) (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyJan 12 2021, 15:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC72559fd6560a: lockedpool: avoid sensitive data in core files (FreeBSD).

Revision Contents
Changeset List

Path

Size

src/

support/

lockedpool.cpp

4 lines

Diff 26880

View Options

src/support/lockedpool.cpp

lockedpool: avoid sensitive data in core files (FreeBSD)ClosedPublicActions