Page MenuHomePhabricator
Differential D1019

Allow disabling wallet build in teamcity build.sh
ClosedPublic
Actions

Authored by schancel on Jan 23 2018, 00:45.

Details

Reviewers
deadalnix
matiu
Group Reviewers
Restricted Project
Commits
rSTAGINGdbf11be8f02c: Allow disabling wallet build in teamcity build.sh
rABCdbf11be8f02c: Allow disabling wallet build in teamcity build.sh
Summary

Allow allow to be disabled in the CI build script via an environment variable.

Test Plan

DISABLE_WALLET=true ./contrib/teamcity/build.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
disabled-wallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1735
Build 1735: arc lint + arc unit

Event Timeline

schancel created this revision.Jan 23 2018, 00:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2018, 00:45
schancel edited the summary of this revision. (Show Details)Jan 23 2018, 00:45
schancel updated this revision to Diff 2694.Jan 23 2018, 00:53

Uncomment autogen

Harbormaster completed remote builds in B1734: Diff 2694.Jan 23 2018, 00:53
deadalnix requested changes to this revision.Jan 23 2018, 01:02
deadalnix added inline comments.
contrib/teamcity/build.sh
37 ↗(On Diff #2694)

Only rpc tests should be skipped.

This revision now requires changes to proceed.Jan 23 2018, 01:02
teamcity added a subscriber: teamcity.Jan 23 2018, 01:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 23 2018, 01:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

teamcity added a comment.Jan 23 2018, 01:23

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 23 2018, 01:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel updated this revision to Diff 2695.Jan 23 2018, 03:02

Only disable RPC tests when wallet is disabled

Harbormaster completed remote builds in B1735: Diff 2695.Jan 23 2018, 03:02
teamcity added a comment.Jan 23 2018, 03:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 23 2018, 03:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix accepted this revision.Jan 23 2018, 10:57
This revision is now accepted and ready to land.Jan 23 2018, 10:57
Closed by commit rABCdbf11be8f02c: Allow disabling wallet build in teamcity build.sh (authored by schancel). · Explain WhyJan 23 2018, 17:11
This revision was automatically updated to reflect the committed changes.
fefivewem added a subscriber: fefivewem.Jun 19 2020, 08:07

Teamcity is a useful software to managing the build and continuous integration some particular ways. You will give your experience paperfellows.com review to allow disabling and change the default setting of Team City.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
33 lines

Diff 2695

View Options

contrib/teamcity/build.sh

Loading...