Page MenuHomePhabricator

gui: use PACKAGE_NAME in exception message
ClosedPublic

Authored by PiRK on Jan 15 2021, 10:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf472f3394cb4: gui: use PACKAGE_NAME in exception message
Summary

This is a backport of Core PR18646

Test Plan
diff --git a/src/qt/modaloverlay.cpp b/src/qt/modaloverlay.cpp
index e5f32fe12..c5686cc0d 100644
--- a/src/qt/modaloverlay.cpp
+++ b/src/qt/modaloverlay.cpp
@@ -7,6 +7,7 @@

 #include <chainparams.h>
 #include <qt/guiutil.h>
+#include <util/check.h>

 #include <QPropertyAnimation>
 #include <QResizeEvent>
@@ -197,6 +198,7 @@ void ModalOverlay::showHide(bool hide, bool userRequested) {
 }

 void ModalOverlay::closeClicked() {
+    CHECK_NONFATAL(false);
     showHide(true);
     userClosed = true;
 }

Running bitcoin-qt and clicking Hide in the modal causes the exception dialog to appear. Check that it includes "Bitcoin ABC".

Event Timeline

PiRK requested review of this revision.Jan 15 2021, 10:18
PiRK edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jan 15 2021, 10:26
This revision was automatically updated to reflect the committed changes.