Page MenuHomePhabricator
Differential D9045

[Cashtab] Implement BigNumber.js for crypto amounts
ClosedPublic
Actions

Authored by bytesofman on Jan 22 2021, 17:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5f96006ad6df: [Cashtab] Implement BigNumber.js for crypto amounts
Summary

Ensure high precision decimals are handled accurately.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add-bignumber-to-validation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14959
Build 29870: Build Diffcashtab-tests
Build 29869: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 22 2021, 17:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2021, 17:06
bytesofman requested review of this revision.Jan 22 2021, 17:06
bytesofman updated this revision to Diff 27274.

Remove unused BigNumber.js import from validation.test.js

Harbormaster completed remote builds in B14959: Diff 27273.Jan 22 2021, 17:09
Harbormaster completed remote builds in B14960: Diff 27274.
bytesofman updated this revision to Diff 27275.Jan 22 2021, 17:14

Ensure testedAmount is still validated as a BigNumber if user selected USD

Harbormaster completed remote builds in B14961: Diff 27275.Jan 22 2021, 17:17
Fabien requested changes to this revision.Jan 22 2021, 19:15
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/cashtab/src/utils/__tests__/validation.test.js
80 ↗(On Diff #27275)

Actually check the value ?

This revision now requires changes to proceed.Jan 22 2021, 19:15
bytesofman updated this revision to Diff 27279.Jan 23 2021, 10:34

Ensure function fiatToCrypto returns a string, add unit test

bytesofman updated this revision to Diff 27280.Jan 23 2021, 10:35

Clarify comment in function

Harbormaster completed remote builds in B14964: Diff 27279.Jan 23 2021, 10:37
Harbormaster completed remote builds in B14965: Diff 27280.
Fabien accepted this revision.Jan 23 2021, 15:03
Fabien added inline comments.
web/cashtab/src/utils/validation.js
39 ↗(On Diff #27280)

with more => with no more

This revision is now accepted and ready to land.Jan 23 2021, 15:03
bytesofman updated this revision to Diff 27283.Jan 23 2021, 15:13

Fix typo in comment, "more" to "no more"

Harbormaster completed remote builds in B14966: Diff 27283.Jan 23 2021, 15:33
Closed by commit rABC5f96006ad6df: [Cashtab] Implement BigNumber.js for crypto amounts (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJan 23 2021, 15:36
This revision was automatically updated to reflect the committed changes.
Joey King <joseph.roy.king@gmail.com> added a commit: rABC5f96006ad6df: [Cashtab] Implement BigNumber.js for crypto amounts.
bytesofman mentioned this in D9052: [Cashtab] Match app send min to backend send min with constant.Jan 25 2021, 12:34
Joey King <joseph.roy.king@gmail.com> mentioned this in rABC89e3cfb7e5e6: [Cashtab] Match app send min to backend send min with constant.Jan 25 2021, 15:09

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
10 lines
utils/
__tests__/
12 lines
20 lines

Diff 27273

View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/utils/__tests__/validation.test.js

Loading...
View Options

web/cashtab/src/utils/validation.js

Loading...