Page MenuHomePhabricator
Differential D9158

Do not bust cached npm-installed dependencies when source files change
ClosedPublic
Actions

Authored by jasonbcox on Feb 3 2021, 21:28.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC5ba6211c6d43: Do not bust cached npm-installed dependencies when source files change
Summary

Similar to D9157, this patch reduces cache busts related to npm packages
and improves rebuild time by ~55% (~70 seconds on my machine).

Depends on D9157

Test Plan

Run this test plan before and after this patch:

docker build --no-cache -t cashtab .

Change a Cashtab source file, then:

docker build -t cashtab .

Sanity check:

docker run -it -p 9000:80 cashtab

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Feb 3 2021, 21:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2021, 21:29
jasonbcox requested review of this revision.Feb 3 2021, 21:29
Harbormaster completed remote builds in B15109: Diff 27523.Feb 3 2021, 21:31
jasonbcox added a child revision: D9159: Use npm ci instead of install for docker deployments.Feb 3 2021, 21:36
majcosta added a subscriber: majcosta.Feb 3 2021, 21:48
majcosta added inline comments.
web/cashtab/Dockerfile
18–20 ↗(On Diff #27523)

you can go even further if you want, just COPY package-lock.json and RUN npm ci

majcosta requested changes to this revision.Feb 3 2021, 21:48
This revision now requires changes to proceed.Feb 3 2021, 21:48
jasonbcox requested review of this revision.Feb 3 2021, 21:58
jasonbcox added inline comments.
web/cashtab/Dockerfile
18–20 ↗(On Diff #27523)

npm ci still uses package.json for reference, as it will error out if package-lock.json does not match package.json

I specifically put npm ci into its own diff in case it generates additional discussion on the impact of reproducible builds (see D9159)

majcosta accepted this revision.Feb 3 2021, 22:13

oh, that's perfect, my bad then

This revision is now accepted and ready to land.Feb 3 2021, 22:13
Closed by commit rABC5ba6211c6d43: Do not bust cached npm-installed dependencies when source files change (authored by jasonbcox). · Explain WhyFeb 4 2021, 16:06
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC5ba6211c6d43: Do not bust cached npm-installed dependencies when source files change.

Revision Contents
Changeset List

PathSize
web/
cashtab/
11 lines

Diff 27554

View Options

web/cashtab/Dockerfile

Loading...