Page MenuHomePhabricator

Add safe flag to listunspent result
ClosedPublic

Authored by deadalnix on Feb 2 2018, 14:18.

Details

Summary

Backport core's PR9830

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
safelistunspent
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1798
Build 1798: arc lint + arc unit

Event Timeline

matiu added inline comments.
src/wallet/rpcwallet.cpp
3117 ↗(On Diff #2793)

Maybe we should remove "and unconfirmed replacement transactions"

src/wallet/wallet.cpp
2304 ↗(On Diff #2793)

remove && pcoin->mapValue.count("replaced_by_txid")

src/wallet/wallet.h
475 ↗(On Diff #2793)

remove "and unconfirmed replacement transactions"

src/wallet/wallet.cpp
2304 ↗(On Diff #2793)

The comment just above it explain why it is still there.

This revision is now accepted and ready to land.Feb 3 2018, 00:25
This revision was automatically updated to reflect the committed changes.