Fix minerfund in GBT when cashaddr is disabled
ClosedPublic
Actions

Authored by jasonbcox on Apr 13 2021, 22:12.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC4b89a7a531f9: Fix minerfund in GBT when cashaddr is disabled

Summary

When testing changes to https://github.com/viabtc/viabtc_mining_server I noticed that -usecashaddr=0 did
not impact the address format for the miner fund in getblocktemplate. This patch fixes that.

While it would be ideal to move away from legacy address support entirely, it's still very common that mining pool software only support the legacy format. Some reasons to not push for cashaddr-only at this time:

Pushing BCH-prefixed cashaddr doesn't make sense strategically at this time. Once the rebranding is completed, we can put energy behind a rebranded prefix cashaddr.
Pools often mine to the same (legacy) address across different chains, so supporting legacy addresses for the time being is important to them to prevent over-complicating their pool configurations.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gbt-legacy-minerfund

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15509
Build 30938: Build Diff	build-debug · build-clang · lint-circular-dependencies · build-clang-tidy · build-without-wallet · build-diff
Build 30937: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 13 2021, 22:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2021, 22:12

jasonbcox requested review of this revision.Apr 13 2021, 22:12

Harbormaster completed remote builds in B15509: Diff 28167.Apr 13 2021, 22:26

Wouldn't moving away imply to not do the translation in more and more places over time?

Is that causing an actual problem for that mining software?

This revision now requires changes to proceed.Apr 14 2021, 12:29

In D9414#213632, @deadalnix wrote:

Wouldn't moving away imply to not do the translation in more and more places over time?

Is that causing an actual problem for that mining software?

It not strictly causing an issue for the pool software. It only makes it more challenging to configure.

IMO this patch doesn't add significant maintenance on its own, but I understand your stance on this. It creeps. We can table it for now.