Page MenuHomePhabricator
Differential D9519

[backport#19177] test: Fix and clean p2p_invalid_messages functional tests
ClosedPublic
Actions

Authored by majcosta on May 13 2021, 01:16.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCc91add32290e: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests
Summary

af2a145e575f23c64909e6cf1fb323c603bda7ca Refactor resource exhaustion test (Troy Giorshev)
5c4648d17ba18e4194959963994cc6b37053f127 Fix "invalid message size" test (Troy Giorshev)
ff1e7b884447a5ba10553b2d964625f94e255bdc Move size limits to module-global (Troy Giorshev)
57890abf2c7919eddfec36178b1136cd44ffe883 Remove two unneeded tests (Troy Giorshev)

Pull request description:

This PR touches only the p2p_invalid_messages.py functional test module.  There are two main goals accomplished here.  First, it fixes the "invalid message size" test, which previously made a message that was invalid for multiple reasons.  Second, it refactors the file into a single consistent style.  This file appears to have originally had two authors, with different styles and some test duplication.

It should now be easier and quicker to understand this module, anticipating the upcoming [BIP324](https://github.com/bitcoin/bitcoin/pull/18242) and [AltNet](https://github.com/bitcoin/bitcoin/issues/18989) changes.

This should probably go in ahead of #19107, but the two are not strictly related.

Depends on D9511

Backport of core#19177

Test Plan
ninja all && ./test/functional/test_runner.py p2p_invalid_messages

Diff Detail

Event Timeline

majcosta created this revision.May 13 2021, 01:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2021, 01:16
majcosta requested review of this revision.May 13 2021, 01:16
teamcity edited the summary of this revision. (Show Details)May 13 2021, 01:16
majcosta added a child revision: D9520: [backport#19264] [tests] Don't import asyncio to test magic bytes.May 13 2021, 01:19
Harbormaster completed remote builds in B15707: Diff 28456.May 13 2021, 01:29
PiRK requested changes to this revision.May 13 2021, 07:37
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/p2p_invalid_messages.py
289

This string seems to have been truncated ("junk messages").

This revision now requires changes to proceed.May 13 2021, 07:37
majcosta updated this revision to Diff 28462.May 13 2021, 11:42

fixed debug log output string

Harbormaster completed remote builds in B15713: Diff 28462.May 13 2021, 11:56
PiRK accepted this revision.May 13 2021, 12:06
This revision is now accepted and ready to land.May 13 2021, 12:06
Closed by commit rABCc91add32290e: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyMay 13 2021, 12:30
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc91add32290e: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests.

Revision Contents
Changeset List

PathSize
test/
functional/
159 lines

Diff 28456

View Options

test/functional/p2p_invalid_messages.py

Loading...