Page MenuHomePhabricator
Differential D9512

[backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic
ClosedPublic
Actions

Authored by majcosta on May 12 2021, 18:44.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa496d457ee5a: [backport#19260] p2p: disconnect peers that send filterclear + update existing…
Summary

3a10d935ac8ebabdfd336569d943f042ff84b13e [p2p/refactor] move disconnect logic and remove misbehaving (gzhao408)
ff8c430c6589ea72b9e169455cf6437c8623cc52 [test] test disconnect for filterclear (gzhao408)
1c6b787e0319c44f0e0bede3f4a77ac7c2089db2 [netprocessing] disconnect node that sends filterclear (gzhao408)

Pull request description:

Nodes that don't have bloomfilters turned on (i.e. no `NODE_BLOOM` service) should disconnect peers that send them `filterclear` P2P messages.

Non-bloomfilter nodes already disconnect peers for [`filteradd` and `filterload`](https://github.com/bitcoin/bitcoin/blob/19e919217e6d62e3640525e4149de1a4ae04e74f/src/net_processing.cpp#L2218), but #8709 removed `filterclear` so it could be used to reset tx relay. This isn't needed now because using `feefilter` message is much better for this purpose (See #19204).

Also refactors existing disconnect logic for `filteradd` and `filterload` into respective message handlers and removes banning for them.

Backport of core#19260

Depends on D9520

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 12 2021, 18:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2021, 18:44
majcosta requested review of this revision.May 12 2021, 18:44
teamcity edited the summary of this revision. (Show Details)May 12 2021, 18:44
majcosta added a child revision: D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups.May 12 2021, 18:55
Harbormaster completed remote builds in B15700: Diff 28439.May 12 2021, 18:56
majcosta updated this revision to Diff 28458.May 13 2021, 01:21
majcosta edited the summary of this revision. (Show Details)
majcosta added a parent revision: D9520: [backport#19264] [tests] Don't import asyncio to test magic bytes.

rebase due to out of order backports

majcosta edited the summary of this revision. (Show Details)May 13 2021, 01:29
Harbormaster completed remote builds in B15709: Diff 28458.May 13 2021, 01:38
PiRK accepted this revision.May 13 2021, 07:08
This revision is now accepted and ready to land.May 13 2021, 07:08
Closed by commit rABCa496d457ee5a: [backport#19260] p2p: disconnect peers that send filterclear + update existing… (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyMay 13 2021, 12:32
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa496d457ee5a: [backport#19260] p2p: disconnect peers that send filterclear + update existing….

Revision Contents
Changeset List

PathSize
src/
27 lines
test/
functional/
7 lines

Diff 28467

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/p2p_nobloomfilter_messages.py

Loading...