Page MenuHomePhabricator
Differential D9544

[avalanche] introduce LimitedProofId
ClosedPublic
Actions

Authored by PiRK on May 18 2021, 10:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCc3cb64a785f8: [avalanche] introduce LimitedProofId
Summary

This stores the intermediate hash generated when building the ProofId as
a member of the Proof class, and adds an accessor.

The next step is to send this limited proof id with the avahello message.

Depends on D9543

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 18 2021, 10:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2021, 10:40
PiRK requested review of this revision.May 18 2021, 10:40
Harbormaster completed remote builds in B15748: Diff 28518.May 18 2021, 10:51
PiRK updated this revision to Diff 28521.May 18 2021, 10:55

ss2 -> ss

Harbormaster completed remote builds in B15749: Diff 28521.May 18 2021, 11:20
deadalnix requested changes to this revision.May 18 2021, 13:14
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/proof.cpp
65 ↗(On Diff #28521)

Really? Do not recompute this twice.

This revision now requires changes to proceed.May 18 2021, 13:14
PiRK updated this revision to Diff 28525.May 18 2021, 14:05

avoid computing the limited proofid twice

Harbormaster completed remote builds in B15751: Diff 28525.May 18 2021, 14:18
PiRK mentioned this in D9509: [avalanche] Send the proof master pubkey with AVAHELLO.May 18 2021, 16:08
PiRK added a child revision: D9509: [avalanche] Send the proof master pubkey with AVAHELLO.May 18 2021, 16:12
deadalnix accepted this revision.May 18 2021, 20:44
This revision is now accepted and ready to land.May 18 2021, 20:44
PiRK added a child revision: D9564: [avalanche] include proof master and limited proofid in the delegation.May 21 2021, 06:49
Closed by commit rABCc3cb64a785f8: [avalanche] introduce LimitedProofId (authored by PiRK). · Explain WhyMay 21 2021, 18:40
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc3cb64a785f8: [avalanche] introduce LimitedProofId.

Revision Contents
Changeset List

PathSize
src/
avalanche/
11 lines
8 lines
11 lines
rpc/
5 lines
test/
functional/
3 lines
test_framework/
23 lines

Diff 28565

View Options

src/avalanche/proof.h

Loading...
View Options

src/avalanche/proof.cpp

Loading...
View Options

src/avalanche/proofid.h

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

test/functional/abc_rpc_avalancheproof.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...