Page MenuHomePhabricator

[avalanche] Add a LimitedProofId::computeProofId method
ClosedPublic

Authored by PiRK on Thu, May 27, 13:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCc2d8667339c4: [avalanche] Add a LimitedProofId::computeProofId method
Summary

The piece of proof.cpp that computes the proodif from the limited id and
from the master key will be needed when we verify that a delegation
matches a given proof. This adds a method to LimitedProofId to do the
computation.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Thu, May 27, 13:44
deadalnix requested changes to this revision.Thu, May 27, 13:59
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/proofid.h
32 ↗(On Diff #28639)

This takes a LimitedProofId has argument, but not a ProofId, so why is it a static method in ProofId rather than a method of LimitedProofId?

This revision now requires changes to proceed.Thu, May 27, 13:59
PiRK retitled this revision from [avalanche] Add a ProofId::fromLimitedId method to [avalanche] Add a LimitedProofId::computeProofId method.
PiRK edited the summary of this revision. (Show Details)

address review

src/avalanche/proofid.cpp
20 ↗(On Diff #28642)

^

deadalnix requested changes to this revision.Fri, May 28, 13:05
This revision now requires changes to proceed.Fri, May 28, 13:05

add newline at the end of proofid.cpp

This revision is now accepted and ready to land.Mon, May 31, 15:16