Page MenuHomePhabricator
Differential D9596

[avalanche] Add a LimitedProofId::computeProofId method
ClosedPublic
Actions

Authored by PiRK on May 27 2021, 13:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCc2d8667339c4: [avalanche] Add a LimitedProofId::computeProofId method
Summary

The piece of proof.cpp that computes the proodif from the limited id and
from the master key will be needed when we verify that a delegation
matches a given proof. This adds a method to LimitedProofId to do the
computation.

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.May 27 2021, 13:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2021, 13:44
PiRK requested review of this revision.May 27 2021, 13:44
Harbormaster completed remote builds in B15829: Diff 28639.May 27 2021, 13:57
deadalnix requested changes to this revision.May 27 2021, 13:59
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/proofid.h
32

This takes a LimitedProofId has argument, but not a ProofId, so why is it a static method in ProofId rather than a method of LimitedProofId?

This revision now requires changes to proceed.May 27 2021, 13:59
PiRK updated this revision to Diff 28641.May 27 2021, 14:16
PiRK retitled this revision from [avalanche] Add a ProofId::fromLimitedId method to [avalanche] Add a LimitedProofId::computeProofId method.
PiRK edited the summary of this revision. (Show Details)

address review

PiRK updated this revision to Diff 28642.May 27 2021, 14:24

mark the method const

Harbormaster completed remote builds in B15831: Diff 28641.May 27 2021, 14:29
PiRK added a child revision: D9564: [avalanche] include proof master and limited proofid in the delegation.May 27 2021, 14:32
Harbormaster completed remote builds in B15832: Diff 28642.May 27 2021, 14:38
deadalnix added inline comments.May 27 2021, 16:44
src/avalanche/proofid.cpp
20 ↗(On Diff #28642)

^

deadalnix requested changes to this revision.May 28 2021, 13:05
This revision now requires changes to proceed.May 28 2021, 13:05
PiRK updated this revision to Diff 28668.May 28 2021, 15:26

add newline at the end of proofid.cpp

Harbormaster completed remote builds in B15848: Diff 28668.May 28 2021, 15:56
deadalnix accepted this revision.May 31 2021, 15:16
This revision is now accepted and ready to land.May 31 2021, 15:16
Closed by commit rABCc2d8667339c4: [avalanche] Add a LimitedProofId::computeProofId method (authored by PiRK). · Explain WhyMay 31 2021, 20:03
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc2d8667339c4: [avalanche] Add a LimitedProofId::computeProofId method.

Revision Contents
Changeset List

PathSize
src/
1 line
avalanche/
7 lines
5 lines
20 lines

Diff 28639

View Options

src/CMakeLists.txt

Loading...
View Options

src/avalanche/proof.cpp

Loading...
View Options

src/avalanche/proofid.h

Loading...
View Options

src/avalanche/proofid.cpp

Loading...