Differential D9603

[refactor] get ValueFromAmount via an implicit Amount::operator UniValue()
ClosedPublic
Actions

Authored by majcosta on May 28 2021, 15:22.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCb789fff5c597: [refactor] get ValueFromAmount via an implicit Amount::operator UniValue()

Summary

the number of decimals of precision that an Amount represents is currently all over the place on the codebase, this is one step to getting it all under one roof.

this seems more correct as well, representing as a UniValue is the Amount's job, not some free function. also less verbose code.

AmountFromValue probably should be an Amount constructor next.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 28 2021, 15:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2021, 15:22

majcosta requested review of this revision.May 28 2021, 15:22

fix oversight on test cases

Harbormaster completed remote builds in B15847: Diff 28666.May 28 2021, 15:43

nvm

remove spurious include in amount_tests.cpp

PiRK accepted this revision.May 28 2021, 19:54

This revision is now accepted and ready to land.May 28 2021, 19:54

Harbormaster completed remote builds in B15850: Diff 28670.May 28 2021, 19:57

Closed by commit rABCb789fff5c597: [refactor] get ValueFromAmount via an implicit Amount::operator UniValue() (authored by majcosta). · Explain WhyMay 28 2021, 20:10

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCb789fff5c597: [refactor] get ValueFromAmount via an implicit Amount::operator UniValue().

PiRK mentioned this in D11563: remove unneeded includes of core_io.h and network.h.Jun 3 2022, 10:43

PiRK mentioned this in rABCc747d3f9db61: remove unneeded includes of core_io.h and network.h.Jun 7 2022, 08:25

Revision Contents
Changeset List

Path

Size

src/

7 lines

10 lines

1 line

11 lines

2 lines

rpc/

2 lines

60 lines

2 lines

7 lines

8 lines

test/

fuzz/

5 lines

2 lines

64 lines

2 lines

util/

moneystr.h

2 lines

wallet/

rpcdump.cpp

2 lines

rpcwallet.cpp

73 lines

Diff 28671

View Options

src/amount.h

View Options

src/amount.cpp

View Options

src/core_io.h

View Options

src/core_write.cpp

View Options

src/rest.cpp

View Options

src/rpc/avalanche.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/fuzz/integer.cpp

View Options

src/test/fuzz/transaction.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/util/moneystr.h

View Options

src/wallet/rpcdump.cpp

View Options

[refactor] get ValueFromAmount via an implicit Amount::operator UniValue()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28671

src/amount.h

src/amount.cpp

src/core_io.h

src/core_write.cpp

src/rest.cpp

src/rpc/avalanche.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/test/fuzz/integer.cpp

src/test/fuzz/transaction.cpp

src/test/rpc_tests.cpp

src/test/script_tests.cpp

src/util/moneystr.h

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

[refactor] get ValueFromAmount via an implicit Amount::operator UniValue()
ClosedPublic
Actions

Revision Contents
Changeset List