Paths

Table of Contentst

Differential D11563

remove unneeded includes of core_io.h and network.h
ClosedPublic
Actions

Authored by PiRK on Jun 3 2022, 10:43.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCc747d3f9db61: remove unneeded includes of core_io.h and network.h

Summary

D9603 remove the need to include core_io.h in a few files

D9665 and D9107 removed the need to include network.h in most files. This is now used only in one place after this commit, so we can look into removing network.{h|cpp} altogether (in a separate commit).

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 3 2022, 10:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2022, 10:43

PiRK requested review of this revision.Jun 3 2022, 10:43

PiRK added a child revision: D11564: drop network.{h|cpp}.

Harbormaster completed remote builds in B19245: Diff 33803.Jun 3 2022, 10:59

sdulfari accepted this revision.Jun 3 2022, 17:46

This revision is now accepted and ready to land.Jun 3 2022, 17:46

Closed by commit rABCc747d3f9db61: remove unneeded includes of core_io.h and network.h (authored by PiRK). · Explain WhyJun 7 2022, 08:25

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc747d3f9db61: remove unneeded includes of core_io.h and network.h.

Revision Contents
Changeset List

Path

Size

src/

1 line

1 line

2 lines

1 line

qt/

bitcoinunits.cpp

1 line

test/

wallettests.cpp

1 line

utilitydialog.cpp

1 line

rpc/

blockchain.cpp

1 line

net.cpp

2 lines

rawtransaction.cpp

1 line

test/

amount_tests.cpp

2 lines

rpc_tests.cpp

1 line

wallet/

init.cpp

1 line

rpcwallet.cpp

1 line

Diff 33852

View Options

src/amount.cpp

View Options

src/bitcoind.cpp

View Options

src/feerate.cpp

View Options

src/init.cpp

View Options

src/qt/bitcoinunits.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/utilitydialog.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/amount_tests.cpp

View Options

src/test/rpc_tests.cpp

View Options

src/wallet/init.cpp

View Options

remove unneeded includes of core_io.h and network.hClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33852

src/amount.cpp

src/bitcoind.cpp

src/feerate.cpp

src/init.cpp

src/qt/bitcoinunits.cpp

src/qt/test/wallettests.cpp

src/qt/utilitydialog.cpp

src/rpc/blockchain.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/test/amount_tests.cpp

src/test/rpc_tests.cpp

src/wallet/init.cpp

src/wallet/rpcwallet.cpp

remove unneeded includes of core_io.h and network.h
ClosedPublic
Actions

Revision Contents
Changeset List