[refactor] deduplicate AmountFromValue
ClosedPublic
Actions

Authored by majcosta on Jun 6 2021, 20:44.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8a9f470950c1: [refactor] deduplicate AmountFromValue

Summary

just use the one defined in rpc/util.h and add a catch block for thrown UniValues in bitcoin-tx

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deduplicate_amountfromvalue

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15921
Build 31742: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 31741: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 6 2021, 20:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2021, 20:44

majcosta requested review of this revision.Jun 6 2021, 20:44

majcosta mentioned this in D9635: [refactor] replace duplicated AmountFromValue function with Amount::Amount(UniValue T).Jun 6 2021, 20:44

Harbormaster completed remote builds in B15921: Diff 28778.Jun 6 2021, 20:51

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_net.py ======

------- Stdout: -------
2021-06-06T20:49:39.459000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210606_204903/rpc_net_131
2021-06-06T20:49:39.971000Z TestFramework (INFO): Test getconnectioncount
2021-06-06T20:49:39.972000Z TestFramework (INFO): Test getpeerinfo
2021-06-06T20:50:39.987000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 126, in main
    self.run_test()
  File "/work/test/functional/rpc_net.py", line 64, in run_test
    self.test_getpeerinfo()
  File "/work/test/functional/rpc_net.py", line 164, in test_getpeerinfo
    self.sync_all()
  File "/work/test/functional/test_framework/test_framework.py", line 582, in sync_all
    self.sync_blocks(nodes)
  File "/work/test/functional/test_framework/test_framework.py", line 554, in sync_blocks
    "".join("\n  {!r}".format(b) for b in best_hash),
AssertionError: Block sync timed out after 60s:
  '75f0ba8e743cfe870c1aea71ce601befd59f90ead6968ab751f32fbce2b5d524'
  '5d41957e19237e3c0964c2be39fabbde06fe1d96d04f188b43270a0b1f554f0a'
2021-06-06T20:50:40.038000Z TestFramework (INFO): Stopping nodes
2021-06-06T20:50:40.090000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210606_204903/rpc_net_131
2021-06-06T20:50:40.090000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210606_204903/rpc_net_131/test_framework.log
2021-06-06T20:50:40.091000Z TestFramework (ERROR): 
2021-06-06T20:50:40.091000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210606_204903/rpc_net_131' to consolidate all logs
2021-06-06T20:50:40.091000Z TestFramework (ERROR): 
2021-06-06T20:50:40.092000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-06T20:50:40.092000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-06T20:50:40.092000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_net.py