Differential D9643

[avalanche] Keep track of the peer creation time
ClosedPublic
Actions

Authored by Fabien on Jun 7 2021, 14:43.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC963d2d852a3a: [avalanche] Keep track of the peer creation time

Summary

Similar to what is done for the transactions, this will be used to filter which proof a peer can request, by only allowing for download the proofs which are in our pool for long enough.
The intent is to improve privacy by preventing peers from being able to guess our proof pool. It is a complementary feature to be used in conjunction with D9642.

There is no change in behavior at this stage.

Ref T1611.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_proof_time

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15934
Build 31768: Build Diff	lint-circular-dependencies · build-debug · build-clang-tidy · build-without-wallet · build-diff · build-clang
Build 31767: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 7 2021, 14:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2021, 14:43

Fabien requested review of this revision.Jun 7 2021, 14:43

Why?

Harbormaster completed remote builds in B15932: Diff 28792.Jun 7 2021, 14:54

Added the rational in the diff summary

Fabien added inline comments.Jun 7 2021, 16:37

src/avalanche/test/processor_tests.cpp
987 ↗	(On Diff #28792)	Note to reviewers: I couldn't figure out how to implement operator<< for TimePoint without bloating the test with a dedicated class that re-implements a lot of things. This is the reason why I used BOOST_CHECK instead of BOOST_CHECK_EQUAL and co for TimePoints