Page MenuHomePhabricator
Differential D9674

refactor: consolidate both ecash CLI options under "-ecash"
ClosedPublic
Actions

Authored by majcosta on Jun 13 2021, 03:53.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC8cdc87e4fc85: refactor: consolidate both ecash CLI options under "-ecash"
Summary

this is more convenient and now it's feasible

Test Plan
ninja all check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
consolidate_xec_and_ecash_options
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15996
Build 31891: Build Diffbuild-without-wallet · lint-circular-dependencies · build-diff · build-clang · build-clang-tidy · build-debug
Build 31890: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 13 2021, 03:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2021, 03:53
majcosta requested review of this revision.Jun 13 2021, 03:53
majcosta updated this revision to Diff 28891.Jun 13 2021, 04:00

remove now unnecessary DEFAULT_XEC constant

Harbormaster completed remote builds in B15996: Diff 28890.Jun 13 2021, 04:09
Harbormaster completed remote builds in B15997: Diff 28891.Jun 13 2021, 04:15
PiRK accepted this revision.Jun 13 2021, 07:56
This revision is now accepted and ready to land.Jun 13 2021, 07:56
PiRK added a comment.Jun 13 2021, 13:28

The description is probably missing a dependency. I can't arc patch this.

Closed by commit rABC8cdc87e4fc85: refactor: consolidate both ecash CLI options under "-ecash" (authored by majcosta). · Explain WhyJun 14 2021, 00:02
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC8cdc87e4fc85: refactor: consolidate both ecash CLI options under "-ecash".

Revision Contents
Changeset List

PathSize
src/
2 lines
7 lines
qt/
2 lines
test/
util/
1 line
test/
functional/
test_framework/
1 line

Diff 28890

View Options

src/amount.cpp

Loading...
View Options

src/currencyunit.cpp

Loading...
View Options

src/qt/bitcoinunits.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...