Page MenuHomePhabricator

[avalanche] Don't check the delegation in the peer manager
ClosedPublic

Authored by Fabien on Jun 30 2021, 19:15.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC8c6013facb05: [avalanche] Don't check the delegation in the peer manager
Summary

The PeerManager::addNode() actually checks the delegation for the
node. This is node the right place to do the check since the peer
manager don't use the delegation ever but only the proof id, and also
doesn't return a proper error message in case of failure. This check is
already performed at the avahello reception which will be the main
callsite for this addNode() method.

Depends on D9719.

Ref T1634.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_addnode_no_delegation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16084
Build 32052: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32051: arc lint + arc unit