- Decimal shift from BCHA to XEC
- Address format change from bitcoincash: and simpleledger: to ecash: and etoken:
- Support for legacy address format
- New assets and logos
- Extension version bump with new assets and logos
- Error handling in price API; disable sending by USD if price API is unavailable or seems to be pulling legacy price
Details
Details
- Reviewers
majcosta Fabien - Group Reviewers
Restricted Project - Commits
- rABC03a21e642df0: [Cashtab] Support for eCash rebrand
npm start
- Send an XEC transaction
- Send an eToken transaction
- Send $1 of XEC
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- rebrand-mvp
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 16090 Build 32061: Build Diff cashtab-tests Build 32060: arc lint + arc unit
Event Timeline
Comment Actions
Modify the loadSavedWallet function to recalculate balances in case of decimal move; remove legacy assets
| web/cashtab/extension/src/components/App.js | ||
|---|---|---|
| 18 ↗ | (On Diff #29022) | This can be deleted from the repo |
| 62 ↗ | (On Diff #29022) | Remove |
| 65 ↗ | (On Diff #29022) | Remove |
| web/cashtab/public/cashtab_bg.png | ||
| 1 ↗ | (On Diff #29022) | Any reason we can't go with that old school x/y-repeat on a smaller image ? There was a noticable download time for this on my connection. |
| web/cashtab/src/components/App.js | ||
| 64 ↗ | (On Diff #29022) | Remove |
| 67 ↗ | (On Diff #29022) | Remove |
| 76 ↗ | (On Diff #29022) | Does this need to be duplicated between the app and the extension ? |
| web/cashtab/src/components/Configure/__tests__/__snapshots__/Configure.test.js.snap | ||
| 1 ↗ | (On Diff #29022) | revert |
| web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap | ||
| 1 ↗ | (On Diff #29022) | Revert |
| web/cashtab/src/components/Send/__tests__/__snapshots__/SendToken.test.js.snap | ||
| 1 ↗ | (On Diff #29022) | This should be @generated as well |
| web/cashtab/src/components/Wallet/__tests__/__snapshots__/Wallet.test.js.snap | ||
| 1 ↗ | (On Diff #29022) | Revert |
| web/cashtab/public/cashtab_bg.png | ||
|---|---|---|
| 1 ↗ | (On Diff #29022) | This is a big improvement and should be done soon after launch, taken as a note. Need to properly size and align the image for the tessellation to work. |
| web/cashtab/src/components/App.js | ||
| 76 ↗ | (On Diff #29022) | There are more elegant solutions available than what I currently have for the extension build. However, with the current setup, the extension version of App.js must be its own file. The most immediate way to do this (which should be done in general) would be to move all styled components into their own files. Taken as a note for improvement opportunities. |