[core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection
ClosedPublic
Actions

Authored by PiRK on Jul 12 2021, 15:52.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC86e28fbbbf28: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection

Summary

This is a backport of core#19724 [2/9]
https://github.com/bitcoin/bitcoin/pull/19724/commits/a6ab1e81f964df131cfa0e11e07bedb3283b823f

Depends on D9770

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16158
Build 32189: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32188: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 12 2021, 15:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2021, 15:52

PiRK requested review of this revision.Jul 12 2021, 15:52

teamcity edited the summary of this revision. (Show Details)Jul 12 2021, 15:53

PiRK edited the summary of this revision. (Show Details)Jul 12 2021, 15:54

PiRK added a parent revision: D9770: [core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to OUTBOUND_FULL_RELAY.

PiRK added a child revision: D9772: [core#19724 3/9][refactor] Restructure logic to check for addr relay..Jul 12 2021, 15:55

Harbormaster completed remote builds in B16158: Diff 29145.Jul 12 2021, 16:11

majcosta accepted this revision.Jul 12 2021, 17:52

This revision is now accepted and ready to land.Jul 12 2021, 17:52

Closed by commit rABC86e28fbbbf28: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyJul 13 2021, 14:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC86e28fbbbf28: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection.

Revision Contents
Changeset List

Path

Size

src/

net.h

7 lines

Diff 29145

View Options

[core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnectionClosedPublicActions