Page MenuHomePhabricator

[core#19724 6/9][refactor] Simplify check for block-relay-only connection.
ClosedPublic

Authored by PiRK on Mon, Jul 12, 16:01.

Details

Summary

Previously we deduced it was a block-relay-only based on presence of the
m_tx_relay structure. Now we have the ability to identify it directly via a
connection type accessor function.

This is a backport of core#19724 [6/9]
https://github.com/bitcoin/bitcoin/pull/19724/commits/1e563aed785565af6b7aed7f7399c52205d8f19c

Depends on D9774

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mon, Jul 12, 16:01

Tail of the build log:

[384/442] Running utility command for check-bitcoin-finalization_tests
[385/442] bitcoin: testing bip32_tests
[386/442] bitcoin: testing sync_tests
[387/442] Running utility command for check-bitcoin-sighashtype_tests
[388/442] Running utility command for check-bitcoin-bip32_tests
[389/442] Running utility command for check-bitcoin-sync_tests
[390/442] bitcoin: testing torcontrol_tests
[391/442] bitcoin: testing settings_tests
[392/442] Running utility command for check-bitcoin-torcontrol_tests
[393/442] Running utility command for check-bitcoin-settings_tests
[394/442] bitcoin: testing timedata_tests
[395/442] bitcoin: testing streams_tests
[396/442] Running utility command for check-bitcoin-timedata_tests
[397/442] bitcoin: testing txvalidationcache_tests
[398/442] bitcoin: testing scriptpubkeyman_tests
[399/442] Running utility command for check-bitcoin-streams_tests
[400/442] Running utility command for check-bitcoin-txvalidationcache_tests
[401/442] Running utility command for check-bitcoin-scriptpubkeyman_tests
[402/442] bitcoin: testing wallet_tests
[403/442] Running utility command for check-bitcoin-wallet_tests
[404/442] bitcoin: testing uint256_tests
[405/442] bitcoin: testing script_standard_tests
[406/442] Running utility command for check-bitcoin-uint256_tests
[407/442] Running utility command for check-bitcoin-script_standard_tests
[408/442] bitcoin: testing serialize_tests
[409/442] Running utility command for check-bitcoin-serialize_tests
[410/442] bitcoin: testing radix_tests
[411/442] bitcoin: testing schnorr_tests
[412/442] bitcoin: testing blockcheck_tests
[413/442] Running utility command for check-bitcoin-radix_tests
[414/442] Running utility command for check-bitcoin-schnorr_tests
[415/442] bitcoin: testing getarg_tests
[416/442] Running utility command for check-bitcoin-blockcheck_tests
[417/442] Running utility command for check-bitcoin-getarg_tests
[418/442] bitcoin: testing versionbits_tests
[419/442] Running utility command for check-bitcoin-versionbits_tests
[420/442] Linking CXX executable src/qt/test/test_bitcoin-qt
[421/442] bitcoin: testing validation_tests
[422/442] bitcoin: testing transaction_tests
[423/442] Running utility command for check-bitcoin-validation_tests
[424/442] bitcoin: testing monolith_opcodes_tests
[425/442] Running utility command for check-bitcoin-transaction_tests
[426/442] Running utility command for check-bitcoin-monolith_opcodes_tests
[427/442] bitcoin: testing crypto_tests
[428/442] Running utility command for check-bitcoin-crypto_tests
[429/442] bitcoin: testing skiplist_tests
[430/442] bitcoin: testing validation_block_tests
[431/442] Running utility command for check-bitcoin-skiplist_tests
[432/442] Running utility command for check-bitcoin-validation_block_tests
[433/442] bitcoin: testing coinselector_tests
[434/442] Running utility command for check-bitcoin-coinselector_tests
[435/442] bitcoin: testing op_reversebytes_tests
[436/442] Running utility command for check-bitcoin-op_reversebytes_tests
[437/442] bitcoin-qt: testing test_bitcoin-qt
[438/442] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[439/442] bitcoin: testing coins_tests
[440/442] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
majcosta requested changes to this revision.Mon, Jul 12, 21:19
majcosta added a subscriber: majcosta.

tests broke

This revision now requires changes to proceed.Mon, Jul 12, 21:19

rebase

I wasn't able to reproduce that error locally. Try to re-reun the CI

This revision is now accepted and ready to land.Tue, Jul 13, 14:17