Page MenuHomePhabricator
Differential D9790

Remove mempool global
ClosedPublic
Actions

Authored by PiRK on Jul 15 2021, 09:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC08e10206cf5c: Remove mempool global
Summary

PR description:

This refactor unlocks some nice potential features, such as, but not limited to:

  • Removing the fee estimates global (would avoid slightly fragile workarounds such as Disable fee estimation in blocksonly mode (by removing the fee estimates global) #18766)
  • Making the mempool optional for a "blocksonly" operation mode

Even absent those features, the new code without the global should be easier to maintain, read and write tests for.

This is a backport of core#19556 [3/3]
https://github.com/bitcoin/bitcoin/pull/19556/commits/fafb381af8279b2d2ca768df0bf68d7eb036a2f9

Depends on D9789

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jul 15 2021, 09:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2021, 09:16
PiRK requested review of this revision.Jul 15 2021, 09:16
teamcity edited the summary of this revision. (Show Details)Jul 15 2021, 09:17
Fabien edited the summary of this revision. (Show Details)Jul 15 2021, 09:25
Fabien accepted this revision.Jul 15 2021, 09:34
This revision is now accepted and ready to land.Jul 15 2021, 09:34
Harbormaster completed remote builds in B16181: Diff 29182.Jul 15 2021, 09:40
teamcity added a comment.Jul 15 2021, 09:40
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_proof_inventory.py ======

------- Stdout: -------
2021-07-15T09:34:43.529000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210715_093440/abc_p2p_proof_inventory_2
2021-07-15T09:34:46.178000Z TestFramework (INFO): Test sending a proof to our peers
2021-07-15T09:34:55.478000Z TestFramework (INFO): Test that we don't send the same inv several times
2021-07-15T09:34:58.270000Z TestFramework (INFO): Test a peer is created on proof reception
2021-07-15T09:34:58.706000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/work/test/functional/test_framework/authproxy.py", line 117, in _request
    return self._get_response()
  File "/work/test/functional/test_framework/authproxy.py", line 183, in _get_response
    http_response = self.__conn.getresponse()
  File "/usr/lib/python3.7/http/client.py", line 1352, in getresponse
    response.begin()
  File "/usr/lib/python3.7/http/client.py", line 310, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.7/http/client.py", line 271, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/usr/lib/python3.7/socket.py", line 589, in readinto
    return self._sock.recv_into(b)
ConnectionResetError: [Errno 104] Connection reset by peer

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_proof_inventory.py", line 293, in run_test
    self.test_receive_proof()
  File "/work/test/functional/abc_p2p_proof_inventory.py", line 126, in test_receive_proof
    wait_until(lambda: proof.proofid in get_proof_ids(node))
  File "/work/test/functional/test_framework/util.py", line 264, in wait_until
    if predicate():
  File "/work/test/functional/abc_p2p_proof_inventory.py", line 126, in <lambda>
    wait_until(lambda: proof.proofid in get_proof_ids(node))
  File "/work/test/functional/test_framework/avatools.py", line 140, in get_proof_ids
    ).proofid for peer in node.getavalanchepeerinfo()]
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 157, in __call__
    'POST', self.__url.path, postdata.encode('utf-8'))
  File "/work/test/functional/test_framework/authproxy.py", line 123, in _request
    return self._get_response()
  File "/work/test/functional/test_framework/authproxy.py", line 183, in _get_response
    http_response = self.__conn.getresponse()
  File "/usr/lib/python3.7/http/client.py", line 1352, in getresponse
    response.begin()
  File "/usr/lib/python3.7/http/client.py", line 310, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python3.7/http/client.py", line 271, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/usr/lib/python3.7/socket.py", line 589, in readinto
    return self._sock.recv_into(b)
ConnectionResetError: [Errno 104] Connection reset by peer
2021-07-15T09:34:58.758000Z TestFramework (INFO): Stopping nodes
------- Stderr: -------
Traceback (most recent call last):
  File "/work/test/functional/abc_p2p_proof_inventory.py", line 300, in <module>
    ProofInventoryTest().main()
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    exit_code = self.shutdown()
  File "/work/test/functional/test_framework/test_framework.py", line 273, in shutdown
    self.stop_nodes()
  File "/work/test/functional/test_framework/test_framework.py", line 501, in stop_nodes
    node.stop_node(wait=wait, wait_until_stopped=False)
  File "/work/test/functional/test_framework/test_node.py", line 413, in stop_node
    self.stop(wait=wait)
  File "/work/test/functional/test_framework/coverage.py", line 48, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 157, in __call__
    'POST', self.__url.path, postdata.encode('utf-8'))
  File "/work/test/functional/test_framework/authproxy.py", line 116, in _request
    self.__conn.request(method, path, postdata, headers)
  File "/usr/lib/python3.7/http/client.py", line 1260, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.7/http/client.py", line 1306, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.7/http/client.py", line 1255, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.7/http/client.py", line 1030, in _send_output
    self.send(msg)
  File "/usr/lib/python3.7/http/client.py", line 970, in send
    self.connect()
  File "/usr/lib/python3.7/http/client.py", line 942, in connect
    (self.host,self.port), self.timeout, self.source_address)
  File "/usr/lib/python3.7/socket.py", line 727, in create_connection
    raise err
  File "/usr/lib/python3.7/socket.py", line 716, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_proof_inventory.py

PiRK updated this revision to Diff 29195.Jul 15 2021, 11:33

rebase onto D9791

Harbormaster completed remote builds in B16188: Diff 29195.Jul 15 2021, 11:56
Closed by commit rABC08e10206cf5c: Remove mempool global (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJul 15 2021, 12:26
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC08e10206cf5c: Remove mempool global.

Revision Contents
Changeset List

PathSize
src/
6 lines
node/
3 lines
1 line
4 lines
rpc/
5 lines
test/
util/
6 lines
1 line
2 lines

Diff 29195

View Options

src/init.cpp

Loading...
View Options

src/node/context.h

Loading...
View Options

src/node/context.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...