As per title.
Ref T1672.
Details
Details
- Reviewers
majcosta - Group Reviewers
Restricted Project - Maniphest Tasks
- T1672: Node software rebrand
- Commits
- rABC92bd0b213b64: Rebrand comments from C++ source files
Read the comments.
arc lint
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- rebrand_comments_cpp
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 16216 Build 32301: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 32300: arc lint + arc unit
Event Timeline
| src/amount.h | ||
|---|---|---|
| 169 ↗ | (On Diff #29235) | this is confusing, maybe it's better to say COIN rather than XEC because when our default unit was the same as our ticker, BCH the comment made sense, but with XEC it isn't immediately clear. |
| src/qt/test/paymentrequestdata.h | ||
| 433 ↗ | (On Diff #29235) | There is no MegXEC unit in the codebase, here you probably want to spell out the 21,000,001,000,000 |