Paths

Table of Contentst

Differential D9976

remove use of getDefaultChangeType in paymentserver.cpp
ClosedPublic
Actions

Authored by PiRK on Aug 30 2021, 12:07.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1c09834d5f06: remove use of getDefaultChangeType in paymentserver.cpp

Summary

As requested in review of D9974:

make the changes to BIP70 related code in its own diff

This removes the last remaining occurence of getDefaultChangeType to enable backporting core#19396.
Our codebase only uses OutputType::LEGACY, so this change is trivial.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

change_auto_paymentserver

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16461
Build 32785: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32784: arc lint + arc unit

Event Timeline

PiRK created this revision.Aug 30 2021, 12:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2021, 12:07

PiRK requested review of this revision.Aug 30 2021, 12:07

teamcity edited the summary of this revision. (Show Details)Aug 30 2021, 12:07

PiRK mentioned this in D9974: refactor: Remove confusing OutputType::CHANGE_AUTO.Aug 30 2021, 12:09

majcosta accepted this revision.Aug 30 2021, 12:19

This revision is now accepted and ready to land.Aug 30 2021, 12:19

Harbormaster completed remote builds in B16461: Diff 29641.Aug 30 2021, 12:32

Closed by commit rABC1c09834d5f06: remove use of getDefaultChangeType in paymentserver.cpp (authored by PiRK). · Explain WhyAug 30 2021, 13:15

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1c09834d5f06: remove use of getDefaultChangeType in paymentserver.cpp.

Revision Contents
Changeset List

Path

Size

src/

qt/

paymentserver.cpp

6 lines

Diff 29641

src/qt/paymentserver.cpp

Loading...