[Cashtab] Standard component for API error msg
ClosedPublic
Actions

Authored by bytesofman on Aug 30 2021, 19:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC64fe2ca3e453: [Cashtab] Standard component for API error msg

Summary

T1769

Cashtab API errors were added incrementally in line with other features. The component appears in several screens and should be standardized.

This diff makes the error msg a standard component.

Test Plan

Edit line 227 of useWallet.js from setApiError(false) to setApiError(true)
npm start
Observe the API error msg on home screen, send screen, settings screen, tokens screen, and send tokens screens; confirm placement and style are ok

Diff Detail

Repository

rABC Bitcoin ABC

Branch

api-error-to-component

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16473
Build 32809: Build Diff	cashtab-tests
Build 32808: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 30 2021, 19:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2021, 19:01

bytesofman requested review of this revision.Aug 30 2021, 19:01

Harbormaster completed remote builds in B16473: Diff 29659.Aug 30 2021, 19:04

OK for that diff, but please make the positioning consistent across the pages in another diff. They all look the same which is great but seems to be located randomly over pages.