Differential D10078

[avalanche] Remove dead test code in the proof builder
ClosedPublic
Actions

Authored by Fabien on Sep 9 2021, 11:42.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC151f44cb99f3: [avalanche] Remove dead test code in the proof builder

Summary

The buildRandom method is no longer used. Specialized functions are used in tests instead.

Ref T1676.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_remove_buildrandom

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16599
Build 33053: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 33052: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 9 2021, 11:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2021, 11:42

Fabien requested review of this revision.Sep 9 2021, 11:42

Fabien added a child revision: D10079: [avalanche] Consistently check ProofBuilder::addUTXO return value.Sep 9 2021, 11:52

Harbormaster completed remote builds in B16599: Diff 29870.Sep 9 2021, 11:57

PiRK accepted this revision.Sep 9 2021, 12:10

This revision is now accepted and ready to land.Sep 9 2021, 12:10

Closed by commit rABC151f44cb99f3: [avalanche] Remove dead test code in the proof builder (authored by Fabien). · Explain WhySep 9 2021, 17:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC151f44cb99f3: [avalanche] Remove dead test code in the proof builder.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

proofbuilder.h

6 lines

proofbuilder.cpp

7 lines

Diff 29870

View Options

src/avalanche/proofbuilder.h