Page MenuHomePhabricator
Differential D10079

[avalanche] Consistently check ProofBuilder::addUTXO return value
ClosedPublic
Actions

Authored by Fabien on Sep 9 2021, 11:52.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC9744008395cb: [avalanche] Consistently check ProofBuilder::addUTXO return value
Summary

And use a [[nodiscard]] to demonstrate it. This ensure we are testing what we expect and not silently discarding duplicated stakes.

Ref T1676.
Depends on D10077 and D10078.

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
avalanche/
4 lines
test/
4 lines
8 lines
23 lines
4 lines

Diff 29919

View Options

src/avalanche/proofbuilder.h

Loading...
View Options

src/avalanche/test/orphanproofpool_tests.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/avalanche/test/proof_tests.cpp

Loading...
View Options

src/avalanche/test/util.cpp

Loading...