Paths

Table of Contentst

Differential D10079

[avalanche] Consistently check ProofBuilder::addUTXO return value
ClosedPublic
Actions

Authored by Fabien on Sep 9 2021, 11:52.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC9744008395cb: [avalanche] Consistently check ProofBuilder::addUTXO return value

Summary

And use a [[nodiscard]] to demonstrate it. This ensure we are testing what we expect and not silently discarding duplicated stakes.

Ref T1676.
Depends on D10077 and D10078.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_check_addUTXO

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16600
Build 33055: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · lint-circular-dependencies
Build 33054: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 9 2021, 11:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2021, 11:52

Fabien requested review of this revision.Sep 9 2021, 11:52

Harbormaster completed remote builds in B16600: Diff 29871.Sep 9 2021, 12:05

PiRK accepted this revision.Sep 9 2021, 13:59

This revision is now accepted and ready to land.Sep 9 2021, 13:59

Closed by commit rABC9744008395cb: [avalanche] Consistently check ProofBuilder::addUTXO return value (authored by Fabien). · Explain WhySep 13 2021, 19:09

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9744008395cb: [avalanche] Consistently check ProofBuilder::addUTXO return value.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

proofbuilder.h

4 lines

test/

orphanproofpool_tests.cpp

4 lines

peermanager_tests.cpp

8 lines

proof_tests.cpp

23 lines

util.cpp

4 lines

Diff 29871

View Options

src/avalanche/proofbuilder.h

View Options

src/avalanche/test/orphanproofpool_tests.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

src/avalanche/test/proof_tests.cpp

View Options

src/avalanche/test/util.cpp

[avalanche] Consistently check ProofBuilder::addUTXO return valueClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29871

src/avalanche/proofbuilder.h

src/avalanche/test/orphanproofpool_tests.cpp

src/avalanche/test/peermanager_tests.cpp

src/avalanche/test/proof_tests.cpp

src/avalanche/test/util.cpp

[avalanche] Consistently check ProofBuilder::addUTXO return value
ClosedPublic
Actions

Revision Contents
Changeset List