HomePhabricator

[avalanche] Consistently check ProofBuilder::addUTXO return value

Description

[avalanche] Consistently check ProofBuilder::addUTXO return value

Summary:
And use a [[nodiscard]] to demonstrate it. This ensure we are testing what we expect and not silently discarding duplicated stakes.

Ref T1676.
Depends on D10077 and D10078.

Test Plan:

ninja all check

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Maniphest Tasks: T1676

Differential Revision: https://reviews.bitcoinabc.org/D10079

Details

Provenance
FabienAuthored on Sep 9 2021, 11:49
FabienPushed on Sep 13 2021, 19:08
Reviewer
Restricted Project
Differential Revision
D10079: [avalanche] Consistently check ProofBuilder::addUTXO return value
Parents
rABC5b58bdb0f7a1: [avalanche] Use an ordered container for stakes in the proof builder
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task